Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #85 #112, Go mod round2 #121

Merged
merged 12 commits into from
Dec 4, 2018
Merged

Close #85 #112, Go mod round2 #121

merged 12 commits into from
Dec 4, 2018

Conversation

ChihChengLiang
Copy link
Collaborator

@ChihChengLiang ChihChengLiang commented Dec 3, 2018 •
edited
Loading

Note

  • For future module update, use make update-go-mod

What was wrong?

How was it fixed?

  • This command gets the package with the latest commit on master branch go get -v github.com/libp2p/go-libp2p-crypto@master.

Cute Animal Picture

put a cute animal picture link inside the parentheses

@ChihChengLiang ChihChengLiang mentioned this pull request Dec 3, 2018
Closed
@ChihChengLiang
Copy link
Collaborator Author

@NIC619 This works now, also I think we can remove gx completely.

@ChihChengLiang ChihChengLiang changed the title Go mod round2 Close #85, Go mod round2 Dec 4, 2018
@ChihChengLiang ChihChengLiang changed the title Close #85, Go mod round2 Close #85 #112, Go mod round2 Dec 4, 2018
@ChihChengLiang
Copy link
Collaborator Author

@mhchia @NIC619 The focus of the review is whether the new setup works on your environments.

@ChihChengLiang ChihChengLiang mentioned this pull request Dec 4, 2018
Merged
NIC619
NIC619 approved these changes Dec 4, 2018
View reviewed changes
Copy link
Collaborator

@NIC619 NIC619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe also update the README file?

Makefile
@@ -7,6 +7,9 @@ deps: gx
gx-go rewrite
python3 ./script/partial-gx-uw.py .

update-go-mod:
GO111MODULE=on go mod download && go mod tidy

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also remove the gx related commands in Makefile.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do those in #125 for better review experience.

@ChihChengLiang
Copy link
Collaborator Author

@NIC619 Thanks for reviewing. After some trying, I feel it's better to update README.md after #127.

mhchia
mhchia approved these changes Dec 4, 2018
View reviewed changes
Copy link
Collaborator

@mhchia mhchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried and it works well! Great work:)

@ChihChengLiang ChihChengLiang merged commit 97121f5 into ethresearch:master Dec 4, 2018
@ChihChengLiang
Copy link
Collaborator Author

Thank you @mhchia & @NIC619 for reviewing ❤️

@ChihChengLiang ChihChengLiang deleted the go-mod-round2 branch December 4, 2018 11:02
@NIC619 NIC619 mentioned this pull request Dec 5, 2018
Closed
This was referenced Dec 8, 2018
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NIC619 NIC619 NIC619 approved these changes

@mhchia mhchia mhchia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChihChengLiang @mhchia @NIC619