Disable semgrep scan local #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qizhou
approved these changes
Dec 8, 2024
|
Is it still required after #116 is merged? |
It will be not required anyone |
|
Close since the issue is solved by #116. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why it failed
CircleCI failed when running on the default branch op-es because it performs a full scan for the default branch, whereas it does an incremental scan (smart contract files from the latest commit) on PR branches. As a result, the PR branch succeeded, but the default branch failed.
What is
semgrepsemgrepis a static analysis tool that scans files using user-defined rules. In this repository, it scans all Solidity files based on the rules defined hereWhat are the errors
The error report is available here.
The report lists 40 findings where SoulGasToken.sol does not follow OP’s code style guidelines. For example:
Named inputs to functions must be prepended with an underscoreWhat is done
Filed an issue to track this.