-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SGT: add E2E test -es #125
Conversation
bb5c052
to
92c2d68
Compare
For the record, could you also update the PR with the commands you run to create the auto-generated files? |
Done |
0316b17
to
52db68f
Compare
Could you update the PR description with additional information to aid review:
|
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some more comments, otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -8,7 +8,8 @@ | |||
} | |||
], | |||
"stateMutability": "nonpayable", | |||
"type": "constructor" | |||
"type": " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this change breaks snapshots-check-no-build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the recent op-es commit pass the snapshots-check-no-build
? I just accepted SoulGasToken.json
file in op-es
. I'll also double check that.
Description
This PR address the issue(#101) of SGT's E2E tests
ABI and go bindings generation
Test
Matched test cases in original
opgeth_test.go
nativaGasPaymentWithoutSGTSuccess
fullSGTInsufficientGasPaymentFail
fullSGTGasPaymentAndNonZeroTxValueWithInsufficientNativeBalanceFail
partialSGTGasPaymentAndNonZeroTxValueWithInsufficientNativeBalanceFail
partialSGTInsufficientGasPaymentFail
nativaGasPaymentWithoutSGTSuccess
fullSGTGasPaymentWithoutNativeBalanceSuccess
fullSGTGasPaymentWithNativeBalanceSuccess
partialSGTGasPaymentSuccess
fullSGTGasPaymentAndNonZeroTxValueWithSufficientNativeBalanceSuccess
partialSGTGasPaymentAndNonZeroTxValueWithSufficientNativeBalanceSuccess
Matched test cases in https://perfect-amphibian-929.notion.site/SWC-Devnet-1282e493e88380648486d4961eb91a8d
TestSGTDepositFunctionSuccess
FullSGTGasPaymentWithoutNativeBalanceSuccess
PartialSGTGasPaymentSuccess
Out of the scope:
fullSGTInsufficientGasPaymentFail
fullNativeInsufficientGasPaymentFail