Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI: fix go tests / env #145

Merged
merged 2 commits into from
Dec 26, 2024
Merged

CircleCI: fix go tests / env #145

merged 2 commits into from
Dec 26, 2024

Conversation

syntrust
Copy link

Use Project Settings/Environment Variables instead of hardcode in config to prevent information leaks.
For the mainnet, a blockPI API Key was newly applied to replace the one from upstream.

The related tests passed include

  • TestApplyExistingOPCM/mainnet
  • TestOPCMLiveChain/sepolia-v1.8.0-rc.3
  • TestOPCMLiveChain/sepolia

Copy link
Collaborator

@blockchaindevsh blockchaindevsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to provide a snapshot so that everyone knows where it's configured(but hiding the values ofc).

@qzhodl
Copy link

qzhodl commented Dec 26, 2024

Is there any rate-limiting issue with the BlockPI API key?

@syntrust
Copy link
Author

Is there any rate-limiting issue with the BlockPI API key?

Not anymore. The issue was caused by using a public RPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants