Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-1356 Fix overlapping/floating buttons in integrations screen #4729

Merged

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Mar 19, 2024

Description Of Changes

The buttons on the integration screen would sometimes overlap or leave big gaps that shouldn't happen.
The buttons should display horizontally and in smaller screen they should stack vertically.

Code Changes

  • Removed spacer
  • Added Stack element configured to stack vertically on smaller screens and horizontally on larger screens

Before changes screenshots

Screen Shot 2024-03-19 at 12 49 08
Captura de pantalla 2024-03-19 a la(s) 11 40 20 a  m

After changes screenshots

Screen Shot 2024-03-19 at 13 12 36
Screen Shot 2024-03-19 at 13 12 43

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 5:03pm

@lucanovera lucanovera requested a review from jpople March 19, 2024 16:33
Copy link

cypress bot commented Mar 19, 2024

Passing run #6767 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 9f8357f into 1759998...
Project: fides Commit: 21c7f5b194 ℹ️
Status: Passed Duration: 00:36 💡
Started: Mar 19, 2024 5:42 PM Ended: Mar 19, 2024 5:42 PM

Review all test suite changes for PR #4729 ↗︎

Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Working as expected!

@lucanovera lucanovera merged commit 79e8c84 into main Mar 19, 2024
13 checks passed
@lucanovera lucanovera deleted the PROD-1356-System-info-Fix-button-style-for-integrations-tab branch March 19, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants