Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix- adds back missing option param #4749

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Fix- adds back missing option param #4749

merged 1 commit into from
Mar 27, 2024

Conversation

eastandwestwind
Copy link
Contributor

Closes unticketed

Description Of Changes

Fix type err in cypress test and on tsx compile.

Code Changes

  • Adds missing param to NoticeConsentButtons component

Steps to Confirm

  • Run npx tsc --noEmit in clients/fides-js

Pre-Merge Checklist

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2024 4:42pm

@eastandwestwind eastandwestwind changed the title Add back options param Fix- adds back missing option param Mar 27, 2024
Copy link

cypress bot commented Mar 27, 2024

Passing run #6901 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 1e5d49d into 19d0c70...
Project: fides Commit: 2f5c0d3410 ℹ️
Status: Passed Duration: 00:35 💡
Started: Mar 27, 2024 4:54 PM Ended: Mar 27, 2024 4:54 PM

Review all test suite changes for PR #4749 ↗︎

@eastandwestwind eastandwestwind merged commit 0df6e55 into main Mar 27, 2024
13 checks passed
@eastandwestwind eastandwestwind deleted the fix-type-err branch March 27, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants