Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select menu being cut off by edges of modals #4757

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Mar 28, 2024

Closes #PROD-1896

Description Of Changes

Fixed an issue where select dropdown menus were being cut off by the edges of modals.

Screenshot 2024-03-28 at 14 24 13

This changes the position property of all the selects across the app; I audited to make sure it wasn't causing problems anywhere else though.

Code Changes

  • Give CustomSelect components a menuPosition of fixed by default
  • Remove ConsentMechanismForm component that wasn't being used anywhere in the UI (this should have been removed with the privacy notice form rework but was overlooked)

Steps to Confirm

  • Navigate to /consent/configure/
  • Click "add vendor" and select a data use and detailed data use
  • Verify options in select dropdown are all visible and can be clicked

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 6:37pm

Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and looking better.

Copy link

cypress bot commented Mar 28, 2024

Passing run #6945 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a4e101c into fa8bcfe...
Project: fides Commit: 2221db467f ℹ️
Status: Passed Duration: 00:33 💡
Started: Mar 28, 2024 6:48 PM Ended: Mar 28, 2024 6:49 PM

Review all test suite changes for PR #4757 ↗︎

@jpople jpople merged commit ec6cad0 into main Mar 28, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-1896/fix-select-menu-position branch March 28, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants