Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update migration to configure canada notice with just ca region #4762

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Mar 29, 2024

Partially closes PROD-1903

done alongside https://github.com/ethyca/fidesplus/pull/1366

Description Of Changes

See ticket (https://ethyca.atlassian.net/browse/PROD-1903) for context

Code Changes

  • update migration

Steps to Confirm

  • checkout an old (2.31.0) version of fides locally, start up the server, turn it off
  • checkout this branch, start up the server, ensure migration runs and that Canada experience has just Canada as a location
    -- this looked good testing with fidesplus, see screenshot post-migration:
    image

Pre-Merge Checklist

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 29, 2024 10:25pm

Copy link

cypress bot commented Mar 29, 2024

Passing run #6969 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 4dfe94c into 321e9d4...
Project: fides Commit: 6ef08f6f95 ℹ️
Status: Passed Duration: 00:32 💡
Started: Mar 29, 2024 10:36 PM Ended: Mar 29, 2024 10:37 PM

Review all test suite changes for PR #4762 ↗︎

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (321e9d4) to head (4dfe94c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4762   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files         338      338           
  Lines       19993    19993           
  Branches     2555     2555           
=======================================
  Hits        17323    17323           
  Misses       2201     2201           
  Partials      469      469           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamsachs adamsachs marked this pull request as ready for review March 29, 2024 22:25
@adamsachs adamsachs requested a review from pattisdr March 29, 2024 22:25
@adamsachs adamsachs merged commit f8a9215 into main Apr 1, 2024
42 checks passed
@adamsachs adamsachs deleted the asachs/PROD-1903_fides branch April 1, 2024 13:11
@cypress cypress bot mentioned this pull request Apr 1, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants