-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include language switcher in the modal #4773
Include language switcher in the modal #4773
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #7130 ↗︎
Details:
Review all test suite changes for PR #4773 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this, and is looking almost perfect!
My main concern is that testing this out locally, upon switching to the Spanish version, I don't see the "on" / "off" text on the toggles:
![Screenshot 2024-04-08 at 6 53 11 PM](https://private-user-images.githubusercontent.com/7697292/320584503-a17c93a3-1d82-4ac2-a54b-da359d97e2e9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NTYwOTgsIm5iZiI6MTczOTU1NTc5OCwicGF0aCI6Ii83Njk3MjkyLzMyMDU4NDUwMy1hMTdjOTNhMy0xZDgyLTRhYzItYTU0Yi1kYTM1OWQ5N2UyZTkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTc1NjM4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjlmNTcyZmMyYTcxZTQ4NzIyM2ViZGEyOWVlYzljNWNkOGJkYzExNGVhN2ViMzUyZjYxZmE0MDMwMmFhZDQ1YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.mVdBiE26ImKS-qz90tqr4GGnMHzBi6MMARz1ULGc8ls)
Here's what the english version looks like:
Is this a new issue or existing? If existing can we create a new ticket to address this?
This appears to be existing and intentional https://github.com/ethyca/fides/blob/main/clients/fides-js/src/components/tcf/RecordsList.tsx#L53-L59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making those changes!
Closes PROD-1908
Description Of Changes
The language picker that was added in PROD-1598 should also be shown in the modal, so that users in areas where the banner doesn’t show can still switch languages.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md