Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include language switcher in the modal #4773

Merged
merged 12 commits into from
Apr 9, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Apr 2, 2024

Closes PROD-1908

Description Of Changes

The language picker that was added in PROD-1598 should also be shown in the modal, so that users in areas where the banner doesn’t show can still switch languages.

CleanShot 2024-04-02 at 17 39 12@2x

Code Changes

  • Broke out Language switcher as own component
  • add globe and caret icons to the language button
  • Display current locale in the language button
  • absolute position language switcher in the modal to drop down on the bottom line and not crowd out the buttons above.

Steps to Confirm

  • Open modal in fides.js demo
  • Open modal in fides.js TCF demo

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 3:08pm

Copy link

cypress bot commented Apr 2, 2024

Passing run #7130 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a069185 into dda0ae2...
Project: fides Commit: c32675f8b8 ℹ️
Status: Passed Duration: 00:35 💡
Started: Apr 9, 2024 3:20 PM Ended: Apr 9, 2024 3:20 PM

Review all test suite changes for PR #4773 ↗︎

Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this, and is looking almost perfect!

My main concern is that testing this out locally, upon switching to the Spanish version, I don't see the "on" / "off" text on the toggles:

Screenshot 2024-04-08 at 6 53 11 PM

Here's what the english version looks like:
Screenshot 2024-04-08 at 6 54 49 PM

Is this a new issue or existing? If existing can we create a new ticket to address this?

clients/fides-js/src/components/ConsentButtons.tsx Outdated Show resolved Hide resolved
clients/fides-js/src/components/LanguageSelector.tsx Outdated Show resolved Hide resolved
@gilluminate
Copy link
Contributor Author

@eastandwestwind

Is this a new issue or existing? If existing can we create a new ticket to address this?

This appears to be existing and intentional https://github.com/ethyca/fides/blob/main/clients/fides-js/src/components/tcf/RecordsList.tsx#L53-L59

Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making those changes!

@gilluminate gilluminate merged commit 40cef1a into main Apr 9, 2024
13 checks passed
@gilluminate gilluminate deleted the PROD-1908-add-language-switcher-to-the-modal branch April 9, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants