Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Encoding and SSL Preference #4790

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Apr 12, 2024

Closes FIDES-611

Description Of Changes

Some discovered Redshift connection issues were found to be related to password character issues along with ssl failures. This PR should make an allowance for both of those

Code Changes

  • url encode database integration passwords for connection strings
  • set ssl mode to prefer for all db connection types

Steps to Confirm

  • Tested live with failing Redshift integration

Pre-Merge Checklist

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 1:35pm

Copy link

cypress bot commented Apr 12, 2024

Passing run #7228 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge cddab15 into 52c6b96...
Project: fides Commit: a84d39656f ℹ️
Status: Passed Duration: 00:33 💡
Started: Apr 12, 2024 1:46 PM Ended: Apr 12, 2024 1:46 PM

Review all test suite changes for PR #4790 ↗︎

@SteveDMurphy SteveDMurphy self-assigned this Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 86.27%. Comparing base (52c6b96) to head (d2ba11e).

Files Patch % Lines
src/fides/api/service/connectors/sql_connector.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4790      +/-   ##
==========================================
- Coverage   86.28%   86.27%   -0.01%     
==========================================
  Files         339      339              
  Lines       20088    20090       +2     
  Branches     2586     2586              
==========================================
  Hits        17333    17333              
- Misses       2289     2291       +2     
  Partials      466      466              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveDMurphy SteveDMurphy requested a review from NevilleS April 12, 2024 13:35
@SteveDMurphy SteveDMurphy marked this pull request as ready for review April 12, 2024 13:35
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@NevilleS
Copy link
Contributor

The failing test here is also happening on our main branch, pretty sure from this: #4788. We'll address that separately. Pulling this in now 👍

@NevilleS NevilleS merged commit 22fa0b9 into main Apr 12, 2024
39 of 40 checks passed
@NevilleS NevilleS deleted the SteveDMurphy-fides-611-redshift-connection-errors branch April 12, 2024 14:10
NevilleS pushed a commit that referenced this pull request Apr 12, 2024
@cypress cypress bot mentioned this pull request Apr 12, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants