Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Black=24.3.0 Formatting Changes #4827

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Apply Black=24.3.0 Formatting Changes #4827

merged 1 commit into from
Apr 24, 2024

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Apr 24, 2024

Closes N/A

Description Of Changes

Followup to: #4807

black was upgraded here but the corresponding formatting changes were not applied.

Code Changes

  • Run nox -s static_checks to apply new formatting fixes
  • Remove py39=true from pyproject.toml and replace with "target-version=["py39"] to resolve Invalid config keys detected: 'py39' (in /../fides/pyproject.toml)

Steps to Confirm

  • N/A - Formatting changes

Pre-Merge Checklist

- Run `nox -s static_checks` to apply new formatting fixes
- Remove py39=true from pyproject.toml and replace with "target-version=["py39"] to resolve Invalid config keys detected: 'py39' (in /Users/Dawn/fides/pyproject.toml)
Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Apr 24, 2024 2:38pm

@pattisdr pattisdr marked this pull request as ready for review April 24, 2024 14:38
@pattisdr pattisdr requested a review from a team as a code owner April 24, 2024 14:38
py39 = true
target-version = ["py39"]
Copy link
Contributor Author

@pattisdr pattisdr Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like py39 = true doesn't work anymore -

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming CI passes! thanks 🙏

Copy link

cypress bot commented Apr 24, 2024

Passing run #7435 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 1d18b23 into 8fc3749...
Project: fides Commit: 2ddaeaec28 ℹ️
Status: Passed Duration: 00:35 💡
Started: Apr 24, 2024 2:59 PM Ended: Apr 24, 2024 2:59 PM

Review all test suite changes for PR #4827 ↗︎

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 84.12698% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 86.87%. Comparing base (8fc3749) to head (1d18b23).

Files Patch % Lines
src/fides/api/util/logger_context_utils.py 42.85% 4 Missing ⚠️
src/fides/api/service/connectors/saas_connector.py 60.00% 2 Missing ⚠️
src/fides/api/db/util.py 0.00% 1 Missing ⚠️
.../service/masking/strategy/masking_strategy_hash.py 50.00% 1 Missing ⚠️
.../service/masking/strategy/masking_strategy_hmac.py 50.00% 1 Missing ⚠️
src/fides/api/task/filter_results.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4827      +/-   ##
==========================================
- Coverage   86.88%   86.87%   -0.01%     
==========================================
  Files         345      345              
  Lines       20786    20785       -1     
  Branches     2717     2718       +1     
==========================================
- Hits        18059    18058       -1     
  Misses       2253     2253              
  Partials      474      474              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pattisdr pattisdr merged commit 128b7d6 into main Apr 24, 2024
40 of 42 checks passed
@pattisdr pattisdr deleted the black_24_3_0_upgrade branch April 24, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants