Update fides_disable_save_api option in FidesJS SDK to disable both privacy-preferences & notice-served APIs #4860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
NevilleS
commented
May 3, 2024
| const historyId1 = "pri_mock_history_id_1"; | ||
| const historyId2 = "pri_mock_history_id_2"; | ||
| const buildMockNotices = (): PrivacyNotice[] => [ |
There was a problem hiding this comment.
DRY'd this up a bit to make these specs easier to read and reuse.
Comment on lines
+100
to
+103
| // Disable the notices-served API if the fides_disable_save_api option is set | ||
| if (options.fidesDisableSaveApi) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
This is all that was actually needed 👍
…ble-notices-served-api
Passing run #7604 ↗︎
Details:
Review all test suite changes for PR #4860 ↗︎ |
|||||||||||||||
eastandwestwind
approved these changes
May 3, 2024
| } | ||
|
|
||
| // Disable the notices-served API if the serving component is a regular | ||
| // banner (or unknown!). This means we trigger the API for: |
There was a problem hiding this comment.
Thanks for adding this helpful comment 👍🏼
| @@ -2338,6 +2290,50 @@ describe("Consent overlay", () => { | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| it("when fides_disable_save_api option is set, disables notices-served & privacy-preferences APIs", () => { | |||
9 tasks
Kelsey-Ethyca
pushed a commit
that referenced
this pull request
May 3, 2024
…rivacy-preferences & notice-served APIs (#4860)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2017
Description Of Changes
This is a small change to make the
fides_disable_save_apioption more consistent; in usage, we expected this to disable all save APIs (both notices-served & privacy-preferences), but as of today only the privacy-preferences API is disabled, which was surprising.As with a lot of PRs, the majority of the changes here are updating the tests 😄
Code Changes
notices-servediffides_disable_save_apioption istrueSteps to Confirm
?fides_disable_save_api=trueas a query paramnotices-servedandprivacy-preferencesare not calledPre-Merge Checklist
CHANGELOG.md