Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show banner title and description input for banner and modal experien… #4892

Conversation

Kelsey-Ethyca
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca commented May 15, 2024

Closes PROD-2014

Description Of Changes

Show banner title and description input for banner and modal experience configs

Code Changes

  • fix conditional

Steps to Confirm

in the admin ui

  • add systems with data uses
  • enable notices
  • enable a banner and modal experience
  • click to edit the banner and modal experience
  • click on a language like English
  • verify the banner title and banner description input fields show
  • change the title and description
  • verify the preview is correct showing the new banner title/description and different modal title/description
    in the fides.js preview
  • add the geolocation query param to match the experience you updated
  • verify the overlays are correct showing the new banner title/description and different modal title/description

Pre-Merge Checklist

Screenshot 2024-05-15 at 1 23 44 PM Screenshot 2024-05-15 at 1 24 27 PM Screenshot 2024-05-15 at 1 24 32 PM

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 8:46pm

Copy link

cypress bot commented May 15, 2024

Passing run #7754 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 6ad6480 into faf56ad...
Project: fides Commit: 9d8b8d8c5b ℹ️
Status: Passed Duration: 00:35 💡
Started: May 15, 2024 8:56 PM Ended: May 15, 2024 8:56 PM

Review all test suite changes for PR #4892 ↗︎

@Kelsey-Ethyca Kelsey-Ethyca merged commit a44b12a into main May 15, 2024
13 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the PROD-2014-add-banner-title-and-description-to-banner-modal-experience-config branch May 15, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants