Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include label in privacy_policy_url validation schema #4942

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jun 3, 2024

Closes PROD-1978

Description Of Changes

Error message for "Privacy policy URL" field was showing code instead of label. This change fixes it to display a label

image

Code Changes

  • update validation schema to include label similar to other fields in this form

Steps to Confirm

  1. In Admin UI, visit Consent Experiences page /consent/privacy-experience
  2. Visit an experience by clicking the table row (eg. "US Modal")
  3. Click a language in the left column (eg. "English (Default)")
  4. Enter a bad URL into the "Privacy policy link URL (optional)" field (eg. "notaurl")
  5. Move cursor focus away from the field to trigger the validation.
  6. Error message should say "Privacy policy URL must be a valid URL"

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 8:16pm

Copy link

cypress bot commented Jun 3, 2024

Passing run #8059 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge a66caf0 into d50f5b3...
Project: fides Commit: ca66b2db08 ℹ️
Status: Passed Duration: 00:36 💡
Started: Jun 3, 2024 4:38 PM Ended: Jun 3, 2024 4:39 PM

Review all test suite changes for PR #4942 ↗︎

@lucanovera
Copy link
Contributor

Fix confirmed
Captura de pantalla 2024-06-04 a la(s) 2 23 37 p  m

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug was fixed. Approved!

@gilluminate gilluminate merged commit 792a041 into main Jun 4, 2024
7 of 8 checks passed
@gilluminate gilluminate deleted the PROD-1978-admin-ui-translation-string branch June 4, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants