Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2202: Allow property-specific messaging to work with non-custom templates #4986

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Jun 14, 2024

Closes https://ethyca.atlassian.net/browse/PROD-2202

Description Of Changes

Allow property-specific messaging to work with non-custom templates

Code Changes

  • Add condition to check for customizable templates before attempting to get property-specific template during message dispatch
  • Add integration test

Steps to Confirm

  • Set FIDES__NOTIFICATIONS__ENABLE_PROPERTY_SPECIFIC_MESSAGING=true
  • Add a generic email connector
  • Test the connection, see that email sends.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 9:16am

@eastandwestwind eastandwestwind requested a review from galvana June 14, 2024 14:02
Copy link

cypress bot commented Jun 14, 2024

Passing run #8361 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c5dbdee into 24e2539...
Project: fides Commit: 8d78535be2 ℹ️
Status: Passed Duration: 00:34 💡
Started: Jun 18, 2024 9:26 AM Ended: Jun 18, 2024 9:26 AM

Review all test suite changes for PR #4986 ↗︎

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.54%. Comparing base (24e2539) to head (c5dbdee).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4986      +/-   ##
==========================================
- Coverage   86.54%   86.54%   -0.01%     
==========================================
  Files         351      351              
  Lines       21738    21739       +1     
  Branches     2878     2878              
==========================================
  Hits        18813    18813              
- Misses       2420     2421       +1     
  Partials      505      505              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this edge-case! I just have one "code-drift" concern that's non-blocking and we can discuss at a later time

@eastandwestwind eastandwestwind merged commit 29305c1 into main Jun 18, 2024
42 checks passed
@eastandwestwind eastandwestwind deleted the PROD-2202 branch June 18, 2024 09:54
Copy link

cypress bot commented Jun 18, 2024

Passing run #8363 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

PROD-2202: Allow property-specific messaging to work with non-custom templates (...
Project: fides Commit: 29305c1129
Status: Passed Duration: 00:33 💡
Started: Jun 18, 2024 10:06 AM Ended: Jun 18, 2024 10:06 AM

Review all test suite changes for PR #4986 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants