-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-2202: Allow property-specific messaging to work with non-custom templates #4986
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #8361 ↗︎
Details:
Review all test suite changes for PR #4986 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4986 +/- ##
==========================================
- Coverage 86.54% 86.54% -0.01%
==========================================
Files 351 351
Lines 21738 21739 +1
Branches 2878 2878
==========================================
Hits 18813 18813
- Misses 2420 2421 +1
Partials 505 505 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this edge-case! I just have one "code-drift" concern that's non-blocking and we can discuss at a later time
Passing run #8363 ↗︎
Details:
Review all test suite changes for PR #4986 ↗︎ |
Closes https://ethyca.atlassian.net/browse/PROD-2202
Description Of Changes
Allow property-specific messaging to work with non-custom templates
Code Changes
Steps to Confirm
FIDES__NOTIFICATIONS__ENABLE_PROPERTY_SPECIFIC_MESSAGING=true
Pre-Merge Checklist
CHANGELOG.md
main
downgrade()
migration is correct and works