Splitting up connector code and tests #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
galvana
added
the
run unsafe ci checks
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5466/merge
|
| Run status |
|
| Run duration | 00m 58s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
Vagoasdf
requested changes
Dec 5, 2024
| """Returns field names in clauses surrounded by quotation marks as required by Snowflake syntax.""" | ||
| return f'"{string_path}" {operator} (:{operand})' | ||
|
|
||
| def _generate_table_name(self) -> str: |
There was a problem hiding this comment.
We're missing this method on the new snowflake query config
galvana
requested review from
Vagoasdf
and removed request for
eastandwestwind
Vagoasdf
approved these changes
Dec 6, 2024
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 55s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
andres-torres-marroquin
pushed a commit
that referenced
this pull request
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes LA-109
Description Of Changes
Breaking up some large code and test files to make them easier to work with, and to make it easier to see which connectors don't have enough test coverage.
Code Changes
sql_connector.pyinto separate files for each connectorquery_config.pyinto separate filestest_request_runner_service.pyinto separate files for each connector. I left generic request runner service tests in the original file.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md