Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pull request template #5470

Merged
merged 3 commits into from
Nov 6, 2024
Merged

update pull request template #5470

merged 3 commits into from
Nov 6, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Nov 6, 2024

Closes HJ-98

Description Of Changes

Updates Fides PR template so at least one item in each section should be checked

  • remove Postman collection requirement
  • add "n/a" options to optional items

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 5:31pm

@galvana galvana self-requested a review November 6, 2024 17:20
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you added the extra checkbox for when something doesn't apply. I was just used to removing the line items that didn't apply to my PRs

@gilluminate
Copy link
Contributor

Can we remove the checkbox next to code changes and steps to confirm? Can we change steps to confirm to a numbered list instead of a bulleted list?

@jpople jpople merged commit 7224448 into main Nov 6, 2024
5 checks passed
@jpople jpople deleted the jpople/update-pr-template branch November 6, 2024 18:50
Copy link

cypress bot commented Nov 6, 2024

fides    Run #10851

Run Properties:  status check passed Passed #10851  •  git commit 722444864f: update pull request template (#5470)
Project fides
Branch Review main
Run status status check passed Passed #10851
Run duration 00m 39s
Commit git commit 722444864f: update pull request template (#5470)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants