Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HJ-166: Support BlueConic objectives #5479

Merged
merged 5 commits into from
Nov 9, 2024
Merged

HJ-166: Support BlueConic objectives #5479

merged 5 commits into from
Nov 9, 2024

Conversation

tvandort
Copy link
Contributor

@tvandort tvandort commented Nov 7, 2024 •
edited by jira bot
Loading

Closes HJ-166

Description Of Changes

Support BlueConic Objectives

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 11:43pm

@tvandort
Copy link
Contributor Author

tvandort commented Nov 7, 2024

Are there any tests I should add this to?

@cypress Cypress
Copy link

cypress bot commented Nov 7, 2024 •
edited
Loading

fides    Run #10905

Run Properties:  status check passed Passed #10905  •  git commit 1d2b37196f ℹ️: Merge ed0997c504344acd198e9ad40505c17fffda0545 into 993aea1a4ca50c8bd367f8be793d...
Project fides
Branch Review refs/pull/5479/merge
Run status status check passed Passed #10905
Run duration 00m 38s
Commit git commit 1d2b37196f ℹ️: Merge ed0997c504344acd198e9ad40505c17fffda0545 into 993aea1a4ca50c8bd367f8be793d...
Committer Tom Van Dort
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@tvandort tvandort force-pushed the HJ-166-support-blueconic-objectives branch from 9412d88 to 041525b Compare November 8, 2024 18:46
@tvandort tvandort force-pushed the HJ-166-support-blueconic-objectives branch from 041525b to 682f5a8 Compare November 8, 2024 18:50
@tvandort tvandort requested a review from gilluminate November 8, 2024 19:05
gilluminate
gilluminate approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Love the new precedent set by having an integrations unit test.

clients/fides-js/src/integrations/shopify.ts Show resolved Hide resolved
NevilleS
NevilleS approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@NevilleS NevilleS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extra notice to add here and a nitpick about docs, but otherwise this is solid. Nice!

NOTE: Accept the suggestion for the notice before merging, so consider this a conditional ✅

clients/fides-js/src/lib/consent-types.ts Show resolved Hide resolved
clients/fides-js/src/lib/consent-constants.ts Show resolved Hide resolved
tvandort and others added 2 commits November 8, 2024 18:36
@tvandort @NevilleS
Update clients/fides-js/src/lib/consent-constants.ts
3ff83af 
Add gpp us national marketing consent key.

Co-authored-by: Neville Samuell <[email protected]>
@tvandort
Update docs interface.
ed0997c
@tvandort tvandort merged commit ea84dc2 into main Nov 9, 2024
13 checks passed
@tvandort tvandort deleted the HJ-166-support-blueconic-objectives branch November 9, 2024 01:11
@cypress Cypress
Copy link

cypress bot commented Nov 9, 2024

fides    Run #10907

Run Properties:  status check passed Passed #10907  •  git commit ea84dc29bf: HJ-166: Support BlueConic objectives (#5479)
Project fides
Branch Review main
Run status status check passed Passed #10907
Run duration 00m 37s
Commit git commit ea84dc29bf: HJ-166: Support BlueConic objectives (#5479)
Committer Tom Van Dort
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Kelsey-Ethyca pushed a commit that referenced this pull request Nov 11, 2024
@tvandort @NevilleS @Kelsey-Ethyca
HJ-166: Support BlueConic objectives (#5479)
e660788 
Co-authored-by: Neville Samuell <[email protected]>
@gilluminate gilluminate mentioned this pull request Nov 14, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

@NevilleS NevilleS NevilleS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvandort @gilluminate @NevilleS