Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LA-165: Fix taxonomy create endpoints #5533

Merged
merged 4 commits into from
Nov 22, 2024
Merged

LA-165: Fix taxonomy create endpoints #5533

merged 4 commits into from
Nov 22, 2024

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Nov 22, 2024 •
edited
Loading

Closes https://ethyca.atlassian.net/browse/LA-165

Description Of Changes

Fides issues with Taxonomy create endpoints

Code Changes

  • Create separate schemas for create body of Taxonomy elements instead of using the DB model

Steps to Confirm

  1. Confirm no regressions- you should be able to create taxonomy elements using the Admin-UI:
Screenshot 2024-11-22 at 6 01 35 PM
  1. Confirm you can create taxonomy elements without specifying a fides key, e.g:
Screenshot 2024-11-22 at 5 58 40 PM

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 7:02pm

@cypress Cypress
Copy link

cypress bot commented Nov 22, 2024 •
edited
Loading

fides    Run #11157

Run Properties:  status check passed Passed #11157  •  git commit 405cf8950d ℹ️: Merge 9feeedc24cdb53e69f0e2446e607a77fdaecf356 into 43b434b6becf0d59afbef5221522...
Project fides
Branch Review refs/pull/5533/merge
Run status status check passed Passed #11157
Run duration 00m 39s
Commit git commit 405cf8950d ℹ️: Merge 9feeedc24cdb53e69f0e2446e607a77fdaecf356 into 43b434b6becf0d59afbef5221522...
Committer Catherine Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Vagoasdf
Vagoasdf approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@Vagoasdf Vagoasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, test passing, validation going forward!

@eastandwestwind eastandwestwind merged commit f4ad746 into main Nov 22, 2024
37 checks passed
@eastandwestwind eastandwestwind deleted the LA-165 branch November 22, 2024 21:35
@cypress Cypress
Copy link

cypress bot commented Nov 22, 2024

fides    Run #11161

Run Properties:  status check passed Passed #11161  •  git commit f4ad7467bd: LA-165: Fix taxonomy create endpoints (#5533)
Project fides
Branch Review main
Run status status check passed Passed #11161
Run duration 00m 39s
Commit git commit f4ad7467bd: LA-165: Fix taxonomy create endpoints (#5533)
Committer Catherine Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

eastandwestwind added a commit that referenced this pull request Nov 22, 2024
@eastandwestwind
LA-165: Fix taxonomy create endpoints (#5533)
e1312dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vagoasdf Vagoasdf Vagoasdf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eastandwestwind @Vagoasdf