Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

La 164 checking oauth access token regeneration #5548

Merged
merged 7 commits into from
Dec 6, 2024
Merged

La 164 checking oauth access token regeneration #5548

merged 7 commits into from
Dec 6, 2024

Conversation

Vagoasdf
Copy link
Contributor

@Vagoasdf Vagoasdf commented Nov 27, 2024 •
edited
Loading

Closes LA#164

Description Of Changes

Updating the connectionconfig authorized method to recognize saas integrations with oauth_client_credentials strategy

Code Changes

connectionconfig::authorized() updated to recognize oauth_client_credentials

Steps to Confirm

  1. Add a PowerReviews integration with valid credentials
  2. Test the connection. It should succed
  3. Now, change Client ID to something invalid
  4. Save the integration and test the connection again
  5. The connection should fail. Previously, the connection succeeded because it uses the old token

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
  • Database migrations:
    • No migrations
  • Documentation:
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 7:23pm

@cypress Cypress
Copy link

cypress bot commented Nov 27, 2024 •
edited
Loading

fides    Run #11337

Run Properties:  status check passed Passed #11337  •  git commit 082ab4c1e6 ℹ️: Merge 657c94019c37014995e3daf64051a6c43a57ca8e into 05cf5efa6ebbf7a63586ad255036...
Project fides
Branch Review refs/pull/5548/merge
Run status status check passed Passed #11337
Run duration 00m 59s
Commit git commit 082ab4c1e6 ℹ️: Merge 657c94019c37014995e3daf64051a6c43a57ca8e into 05cf5efa6ebbf7a63586ad255036...
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@Vagoasdf Vagoasdf force-pushed the LA-164-Checking-Oauth-Access-token-regeneration branch from 649e772 to 36a02af Compare December 5, 2024 18:01
@Vagoasdf Vagoasdf requested a review from galvana December 5, 2024 18:02
@Vagoasdf Vagoasdf marked this pull request as ready for review December 5, 2024 18:06
galvana
galvana reviewed Dec 6, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Vagoasdf @galvana
Update CHANGELOG.md
5ca7eb0 
Co-authored-by: Adrian Galvan <[email protected]>
galvana
galvana approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, I won't block this, but let's make sure we have a quick follow up ticket to add a test

@Vagoasdf
Copy link
Contributor Author

Vagoasdf commented Dec 6, 2024

This makes sense, I won't block this, but let's make sure we have a quick follow up ticket to add a test
Do we have some tests for creating/updating a configuration we can base this on?

@Vagoasdf Vagoasdf merged commit 7abb307 into main Dec 6, 2024
36 of 37 checks passed
@Vagoasdf Vagoasdf deleted the LA-164-Checking-Oauth-Access-token-regeneration branch December 6, 2024 19:43
@cypress Cypress
Copy link

cypress bot commented Dec 6, 2024

fides    Run #11339

Run Properties:  status check passed Passed #11339  •  git commit 7abb307ed8: La 164 checking oauth access token regeneration (#5548)
Project fides
Branch Review main
Run status status check passed Passed #11339
Run duration 00m 49s
Commit git commit 7abb307ed8: La 164 checking oauth access token regeneration (#5548)
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

andres-torres-marroquin pushed a commit that referenced this pull request Dec 11, 2024
@Vagoasdf @galvana @andres-torres-marroquin
La 164 checking oauth access token regeneration (#5548)
1420bbb 
Co-authored-by: Adrian Galvan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvana galvana galvana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vagoasdf @galvana