Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HJ-319 Updated updated_at field of DBCache even when value doesn't change #5670

Merged
merged 2 commits into from
Jan 14, 2025
Merged

HJ-319 Updated updated_at field of DBCache even when value doesn't change #5670

merged 2 commits into from
Jan 14, 2025

Conversation

erosselli
Copy link
Contributor

@erosselli erosselli commented Jan 14, 2025 •
edited
Loading

Relates to HJ-319

Description Of Changes

When set_cache_value is called, we want to update the updated_at value for that cache entry, even if the value provided is the same as the previous one.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2025 6:17pm

@erosselli erosselli requested a review from adamsachs January 14, 2025 18:17
@cypress Cypress
Copy link

cypress bot commented Jan 14, 2025

fides    Run #11751

Run Properties:  status check passed Passed #11751  •  git commit 14d82faa91 ℹ️: Merge ebcc49fff10d5c82f2076b35ed7be82d31a6f1d7 into de209feb31ce2619c9db608d41fa...
Project fides
Branch Review refs/pull/5670/merge
Run status status check passed Passed #11751
Run duration 00m 50s
Commit git commit 14d82faa91 ℹ️: Merge ebcc49fff10d5c82f2076b35ed7be82d31a6f1d7 into de209feb31ce2619c9db608d41fa...
Committer erosselli
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

adamsachs
adamsachs approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the test!

@erosselli erosselli merged commit 4103da1 into main Jan 14, 2025
72 checks passed
@erosselli erosselli deleted the HJ-319-v3 branch January 14, 2025 20:10
@cypress Cypress
Copy link

cypress bot commented Jan 14, 2025

fides    Run #11754

Run Properties:  status check passed Passed #11754  •  git commit 4103da1233: HJ-319 Updated updated_at field of DBCache even when value doesn't change (#5670...
Project fides
Branch Review main
Run status status check passed Passed #11754
Run duration 00m 48s
Commit git commit 4103da1233: HJ-319 Updated updated_at field of DBCache even when value doesn't change (#5670...
Committer erosselli
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs adamsachs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erosselli @adamsachs