Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing install python 3.10 #5674

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Add missing install python 3.10 #5674

merged 4 commits into from
Jan 15, 2025

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jan 15, 2025

Description Of Changes

Fix failing CI jobs that are missing the specific python version install.

Code Changes

  • Add missing python install steps in different workflows
  • Add missing env variables for default python version

Steps to Confirm

  1. CI fully passed

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 15, 2025 9:03pm

Copy link

cypress bot commented Jan 15, 2025

fides    Run #11791

Run Properties:  status check passed Passed #11791  •  git commit e6fe342b22 ℹ️: Merge 27bdca1703a1e26c4f404e0eafb054ddcae435c0 into b3cb8d0e73e96afb7232da94c486...
Project fides
Branch Review refs/pull/5674/merge
Run status status check passed Passed #11791
Run duration 01m 08s
Commit git commit e6fe342b22 ℹ️: Merge 27bdca1703a1e26c4f404e0eafb054ddcae435c0 into b3cb8d0e73e96afb7232da94c486...
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@lucanovera lucanovera merged commit c6fa9d3 into main Jan 15, 2025
17 checks passed
@lucanovera lucanovera deleted the fix-pipeline-python-issue branch January 15, 2025 21:06
Copy link

cypress bot commented Jan 15, 2025

fides    Run #11792

Run Properties:  status check passed Passed #11792  •  git commit c6fa9d3594: Add missing install python 3.10 (#5674)
Project fides
Branch Review main
Run status status check passed Passed #11792
Run duration 00m 51s
Commit git commit c6fa9d3594: Add missing install python 3.10 (#5674)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (b3cb8d0) to head (27bdca1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5674   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files         388      388           
  Lines       24033    24033           
  Branches     2594     2594           
=======================================
  Hits        20943    20943           
  Misses       2529     2529           
  Partials      561      561           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants