Datadog log formatting #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Build CI against modern rubies I am not comfortable deprecating support for 2.1/2.2/2.3 etc until it starts becoming a pain point at run-time due to deprecation warnings, or when adding new features or fixing bugs. * Tempfile is not included in stdlib in modern ruby Depending on it implicitly seems like the kind of thing that could cause downstream suffering.
* Developers may include debug messages in their application logs There were some breaking changes with how the griddler gem was packaged. This caused rake to fail until we downloaded the photos and updated the spec helper. * Use Ruby 2.0 compliant syntax for defining protected methods
There appear to be several ways SPF fails where an application may want to still receive those messages. See [RFC4408 Section 2.5](https://tools.ietf.org/html/rfc4408#section-2.5) to determine whether a particular use case conforms to the SPF standard. Co-authored-by: Eric Lund <[email protected]>
Not sure why, but when an email has `dkim` it sets the spf to `nil` even
if the domain *does* have a working `spf` record.
This starts to treat `nil` `spf` values as `none`
Example body:
```rb
[{"event"=>"inbound",
"ts"=>1682029694,
"msg"=> {
# ...
"spf"=>{"result"=>nil, "detail"=>nil},
"dkim"=>{"signed"=>true, "valid"=>true},
}
}]
```
…ow to configure it outside the gem
etlund
force-pushed
the
datadog-log-formatting
branch
from
4194fca to
6bd302d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.