Fixed setAdapter bug #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adapter should be mAdapter, otherwise when adding header view, mItemCount will get the original adapter's getCount(), which doesn't count the number of headers and/or footers. Later on in layoutChildren() method it'll throw IllegalStateException, because the number of mItemCount and mAdapter.getCount() will never be equal.
|
Good find. The immediately following code that sets the dataset observer and the view type count on the recycle bin is also wrong. I'll fix this up. Thanks :) |
denizmveli
added a commit
that referenced
this pull request
Apr 6, 2014
Merged pull request #86 - Fixed setAdapter bug
|
Thank you! A really nice library, I wish I found it earlier... |
denizmveli
added a commit
that referenced
this pull request
Apr 6, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adapter should be mAdapter, otherwise when adding header view, mItemCount will get the original adapter's getCount(), which doesn't count the number of headers and/or footers. Later on in layoutChildren() method it'll throw IllegalStateException, because the number of mItemCount and mAdapter.getCount() will never be equal.