Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add actions workflows to check compilation on glibc and musl (devuan, alpine) #206

Merged
merged 2 commits into from
Sep 30, 2021
Merged

add actions workflows to check compilation on glibc and musl (devuan, alpine) #206

merged 2 commits into from
Sep 30, 2021

Conversation

ArsenArsen
Copy link
Member

I'm not sure about using those devuan images, though, dyne should be alright?

perhaps the action can be made better?

@ArsenArsen ArsenArsen force-pushed the master branch 3 times, most recently from 5b45abd to 0a0e098 Compare September 30, 2021 10:26
lu-zero
lu-zero approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for a first iteration.

@bbonev
Copy link
Member

bbonev commented Sep 30, 2021

Looks good, lets merge it and then we can always amend that

@ArsenArsen ArsenArsen marked this pull request as draft September 30, 2021 19:41
@ArsenArsen ArsenArsen force-pushed the master branch 7 times, most recently from 03e23be to e161160 Compare September 30, 2021 20:32
@ArsenArsen ArsenArsen marked this pull request as ready for review September 30, 2021 20:38
@bbonev bbonev self-requested a review September 30, 2021 20:53
bbonev
bbonev approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@bbonev bbonev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbonev bbonev merged commit ea6124b into eudev-project:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbonev bbonev bbonev approved these changes

@lu-zero lu-zero lu-zero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArsenArsen @bbonev @lu-zero