Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CONTRIBUTING to reflect updated governance, clarify systemd commit hash requirements #211

Merged
merged 1 commit into from
Nov 5, 2021
Merged

update CONTRIBUTING to reflect updated governance, clarify systemd commit hash requirements #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions CONTRIBUTING
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ You can delete a remote branch by doing
Reported-by: Snoopy Coderdog <[email protected]>
Signed-off-by: Anthony G. Basile <[email protected]>

Patches cherry-picked from systemd-udev must reference the commit hash of
the version committed into systemd-udev git, *not* the version in the systemd
PR.

If you commit using

git commit -s
Expand All @@ -108,21 +112,12 @@ doing
Then push it to your public repo.


4.a Open an issue at (using GitHub)

https://github.com/gentoo/eudev/issues?state=open

And request a pull of your clean commit. A team member will review it,
discuss it and commit it to master or reject it.
4. Open a pull request at GitHub

https://github.com/eudev-project/eudev/compare

4.b Send to mailing list (using git format-patch)
Make sure you are subscribe on the mailing list. If you do not, send an email to
[email protected]
and follow instructions.
A team member will review it, discuss it and commit it to master or reject it.

When sending patches to mailing list, use
git send-email --to [email protected] 0001-foo-bar.patch

5. eudev is a peer-reviewed project. So even team members must ask another
team member to sign-off and commit your work. The only exception are trivial
Expand Down