-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: add memory bound checks for cpp runtime #66
Conversation
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
==========================================
+ Coverage 64.74% 73.27% +8.52%
==========================================
Files 10 10
Lines 919 954 +35
==========================================
+ Hits 595 699 +104
+ Misses 324 255 -69
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please seperate the test and memory check implement in two pr?
@@ -24,4 +24,5 @@ set(skel_includes | |||
|
|||
set(test_sources | |||
src/bpf_api_test.cpp | |||
src/memory_check_test_driver.cpp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the same format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
memory_check_test_driver.cpp
is not a single test, it's a wasm program runner and will run two wasm programs as test. I made this to avoid writting two duplicated source files.
f143d5f
to
fa970a9
Compare
This pull request only contains changes that add memory bound check for cpp runtime