Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add memory bound checks for cpp runtime #66

Merged
merged 10 commits into from
Mar 11, 2023

Conversation

Officeyutong
Copy link
Contributor

@Officeyutong Officeyutong commented Mar 10, 2023

This pull request only contains changes that add memory bound check for cpp runtime

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #66 (3621bf8) into main (a55b78b) will increase coverage by 8.52%.
The diff coverage is 100.00%.

❗ Current head 3621bf8 differs from pull request most recent head a4685c3. Consider uploading reports for the commit a4685c3 to get more accurate results

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   64.74%   73.27%   +8.52%     
==========================================
  Files          10       10              
  Lines         919      954      +35     
==========================================
+ Hits          595      699     +104     
+ Misses        324      255      -69     
Impacted Files Coverage Δ
runtime/wasm-bpf-rs/src/lib.rs 99.25% <100.00%> (+24.25%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

runtime/cpp/cmake/SourcesAndHeaders.cmake Outdated Show resolved Hide resolved
runtime/cpp/include/bpf-api.h Outdated Show resolved Hide resolved
runtime/cpp/test/src/bpf_api_test.cpp Outdated Show resolved Hide resolved
runtime/cpp/include/bpf-api.h Outdated Show resolved Hide resolved
runtime/cpp/src/wasm-bpf.cpp Show resolved Hide resolved
runtime/cpp/src/wasm-bpf.cpp Outdated Show resolved Hide resolved
runtime/cpp/src/wasm-bpf.cpp Outdated Show resolved Hide resolved
Copy link
Member

@yunwei37 yunwei37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please seperate the test and memory check implement in two pr?

runtime/cpp/include/bpf-api.h Outdated Show resolved Hide resolved
@@ -24,4 +24,5 @@ set(skel_includes

set(test_sources
src/bpf_api_test.cpp
src/memory_check_test_driver.cpp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the same format

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

memory_check_test_driver.cpp is not a single test, it's a wasm program runner and will run two wasm programs as test. I made this to avoid writting two duplicated source files.

runtime/cpp/include/bpf-api.h Outdated Show resolved Hide resolved
runtime/cpp/include/bpf-api.h Outdated Show resolved Hide resolved
runtime/cpp/include/bpf-api.h Outdated Show resolved Hide resolved
@Officeyutong Officeyutong force-pushed the main branch 2 times, most recently from f143d5f to fa970a9 Compare March 11, 2023 12:32
@Officeyutong Officeyutong merged commit fc8eef2 into eunomia-bpf:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants