Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: locales for feature notifications #2388

Merged
merged 4 commits into from
Jul 2, 2024
Merged

feat: locales for feature notifications #2388

merged 4 commits into from
Jul 2, 2024

Conversation

rwd
Copy link
Contributor

@rwd rwd commented Jun 28, 2024 •
edited
Loading

  • permit restricting feature notifications by UI locale, like APP_FEATURE_NOTIFICATION_LOCALES=en,nl
  • refactor feature notification display logic to move most of it out of default layout and into @/features/notifications
  • move the rendering of the notification text into the component, instead of a slot supplied by the default layout
  • when the "show me" link in the notification is clicked, hide the toast
  • add a feature notification for the immersive stories

@github-actions GitHub Actions
Copy link

JIRA ticket: EC-6840

@rwd rwd changed the title feat: immersive stories notification feat: locales for feature notifications Jun 28, 2024
@rwd rwd marked this pull request as ready for review July 1, 2024 12:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

Preview deployment: https://pr-2388.portal-js.dev.eanadev.org/

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@LeoniePeters LeoniePeters merged commit 8a992ea into master Jul 2, 2024
27 of 29 checks passed
@LeoniePeters LeoniePeters deleted the feat/EC-6840-stories-feature-notification branch July 2, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeoniePeters LeoniePeters LeoniePeters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwd @LeoniePeters @lbiedinger