Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate Docker Compose file to run app #2393

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

rwd
Copy link
Contributor

@rwd rwd commented Jul 10, 2024

  1. Adds a a new Docker Compose YAML file to run the app along with the rest of the services.

    Run with docker compose -f docker-compose.app.yml up

    App will be exposed on port 8080 on the host.

    Example: run with different published image tags:

    # v1.154.0
    TAG=1.154.0 docker compose -f docker-compose.app.yml up
    
    # v1.155.0
    TAG=1.155.0 docker compose -f docker-compose.app.yml up
  2. Adds IIIF_PRESENTATION_PLUGIN as a build argument for the app Docker image.

    Example: build & run local branch with different IIIF Presentation plugins:

    # mirador
    IIIF_PRESENTATION_PLUGIN=mirador TAG=${IIIF_PRESENTATION_PLUGIN} \
      docker compose -f docker-compose.app.yml up --build
    
    # list-props
    IIIF_PRESENTATION_PLUGIN=list-props TAG=${IIIF_PRESENTATION_PLUGIN} \
      docker compose -f docker-compose.app.yml up --build

Copy link

Preview deployment: https://pr-2393.portal-js.dev.eanadev.org/

Copy link

@rwd rwd merged commit 8083ea8 into master Jul 10, 2024
16 of 17 checks passed
@rwd rwd deleted the chore/docker-compose-file-for-app branch July 10, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant