Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update item language selector #2480

Merged
merged 18 commits into from
Nov 20, 2024

Conversation

LeoniePeters
Copy link
Contributor

@LeoniePeters LeoniePeters commented Nov 15, 2024

  • Refactor ItemLanguageSelector template into one dropdown
    • Redirects to login before showing the dropdown (clicking the toggle button)
    • When language is selected it mentions the language in the toggle button and adds an option to the dropdown to remove the selected language
    • Mobile: no text and status indicator up to small breakpoint
    • When there is an error, the dropdown is disabled and there is a helptext underneath
  • Moves the updated ItemLanguageSelector component down the item page
  • Refactor swiper-height SCSS mixin
    • Renamed to media-viewer-height
    • no longer needs to account for extra height when closing the language selector
    • adds the height available now the language selector is moved down to the media-viewer-height (3.5rem)
    • Extended with styles to prevent feedback button overlap
  • Use media-viewer-height mixin for embeds
  • Adds ItemLanguageSelector to the style guide

Copy link

JIRA ticket: EC-6948

Copy link

Preview deployment: https://pr-2480.portal-js.dev.eanadev.org/

@LeoniePeters LeoniePeters added the styleguide Build and deploy a style guide preview label Nov 19, 2024
Copy link

Style guide deployment: https://pr-2480.styleguide.dev.eanadev.org/

@lbiedinger lbiedinger merged commit ccec53d into master Nov 20, 2024
16 of 17 checks passed
@lbiedinger lbiedinger deleted the feat/EC-6948-update-metadata-translation-dropdown branch November 20, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
styleguide Build and deploy a style guide preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants