refactor: loading spinner on initial IIIF image load #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rwd
commented
Dec 12, 2024
rwd
commented
- show the loading spinner as soon as the viewer component starts fetching, i.e. also during iiif info.json retrieval and initial load of iiif or static image
- zooming in or panning a iiif image will not bring the spinner back
- changing the page will bring the spinner back
- also clear all the layers from the ol map while fetching so that old annotations and images from previous pages or items don't hang around
|
Preview deployment: https://pr-2516.portal-js.dev.eanadev.org/ |
|
lbiedinger
approved these changes
Dec 12, 2024
LeoniePeters
deleted the
refactor/loading-spinner-on-first-iiif-image-load
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.