Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor text fixes #286

Merged
merged 2 commits into from
Nov 27, 2023
Merged

minor text fixes #286

merged 2 commits into from
Nov 27, 2023

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Nov 27, 2023

Fix a couple typos and correct set_solid_harmonics_ordering advice after new comment in #285 initialize.h

@loriab
Copy link
Collaborator Author

loriab commented Nov 27, 2023

fwiw, Psi4 has been using set_sho after initialize for months https://github.com/psi4/psi4/blob/master/psi4/src/core.cc#L1060-L1068 without problems. gtk that's not advised; I'll switch it around.

@evaleev
Copy link
Owner

evaleev commented Nov 27, 2023

fwiw, Psi4 has been using set_sho after initialize for months https://github.com/psi4/psi4/blob/master/psi4/src/core.cc#L1060-L1068 without problems. gtk that's not advised; I'll switch it around.

as long as it's immediately after it's fine ... but it's easier in the dox to say before ... passing as an arg to initialize would be best, of course, but I understand the python issues (would giving verbose argument a stronger type solve that issue?)

@evaleev evaleev merged commit 01e72e7 into evaleev:master Nov 27, 2023
@loriab loriab deleted the loriab-patch-1 branch November 27, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants