Add option to add error breadcrumb in sentry log #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
pkg/errors
a problem we keep encountering is that sentry truncates the error message, which removes relevant information that has been annotated on the error viaWrapf
. I looked into adding this into the StackTraceFrame but it would include a mountain of changes including ones upstream in raven-go.This instead adds a new option
IncludeErrorBreadcrumb
which when true will add a breadcrumb to the sentry report that includes the verbose print of the error. When usingpkg/errors
this gives you a full trace including the annotations.Totally understand if this isn't something you want to merge but leaving this here as maybe it will be useful to others. The "right" way to do this is to annotate each StackTraceFrame with
vars
in the cases where there is an annotation. This would require tweakingpkg/errors
to get at the error message at that level (and not only the recursive error message) and tweakinggetsentry/raven-go
to let us setvars
on a StackTraceFrame.