Removed redundant gates and updated gate tests #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The redundant gates included: Rzy, rU1, and rU2. The purpose of the Rzy gate was to rotate between the Z and Y computational bases. However, the same can be accomplished with the Rx(pi/2) gate. The rU1 gate was equivalent to Ry(2 * theta). The rU2 gate was equal to rU1 \otimes I.
The redundant gates have been removed and the same is true for their corresponding test cases.
Another possible candidate is the A gate (Givens rotation), which can be implemented using standard Ry and CNOT gates. This needs some further consideration.
All tests pass successfully.
User Notes
Checklist