-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript Types #109
Comments
That would be a welcome addition and I haven't been working on that. |
Put this into a file declare module "geo-tz" {
export default function (lat: number, lng: number): string[];
} |
@evansiroky I submitted a PR for adding type definitions #112 |
I suppose I could have done a better job communicating my thoughts around adding TypeScript. Instead of adding a quick definition file, I wanted to add TypeScript to the entire project and properly include it in releases. However, I felt like that was too high of a bar to ask people to clear, so I sort of stayed silent until I found the time and motivation to add TypeScript everywhere in the project. That should be accomplished in #128. |
🎉 This issue has been resolved in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi! We're going to be using this library with our typescript codebase so I was going to make declaration files. If you'd like i can put up a PR to get them into DefinitelyTyped. I just wanted to check in and make sure I wasn't duplicating effort or the maintainers of this package didn't have another plan for TS types. Thanks!
The text was updated successfully, but these errors were encountered: