Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type definitions #112

Closed
wants to merge 1 commit into from
Closed

Conversation

wlbrough
Copy link

This PR adds a type definition file for the package. The default export has very simple types, but the store property in the setCache method has relatively complex nested types. I attempted to capture all of the details of input and output from the store functions based on the code, but I'm not 100% that they are exactly correct. Let me know if you have any feedback or requests!

@wlbrough wlbrough mentioned this pull request Nov 24, 2020
@BrodaNoel
Copy link

Let's do it!

@mutantcornholio
Copy link

@evansiroky any chance on landing this?

@evansiroky
Copy link
Owner

@wlbrough, thanks for taking the time to propose the addition of TypeScript. I have opted instead to fully convert this project to use TypeScript in #128 which will supersede this PR.

@evansiroky evansiroky closed this Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants