fix #272: dynamic import doubling as entry point

CHANGELOG.md

@@ -14,6 +14,10 @@
 
     Re-exporting a symbol in an entry point didn't correctly track the cross-chunk dependency, which caused the output file to be missing a required import. This bug has been fixed.
 
+* Fix code splitting if a dynamic entry point is doubled as a normal entry point ([#272](https://github.com/evanw/esbuild/issues/272))
+
+    Using a dynamic `import()` expression automatically adds the imported path as an entry point. However, manually adding the imported path to the bundler entry point list resulted in a build failure. This case is now handled.
+
 ## 0.6.3
 
 * Fix `/* @__PURE__ */` IIFEs at start of statement ([#258](https://github.com/evanw/esbuild/issues/258))

internal/bundler/bundler_splitting_test.go

@@ -577,3 +577,34 @@ export {
 		},
 	})
 }
+
+func TestSplittingDynamicImportIssue272(t *testing.T) {
+	expectBundled(t, bundled{
+		files: map[string]string{
+			"/a.js": `
+				import('./b')
+			`,
+			"/b.js": `
+				export default 1
+			`,
+		},
+		entryPaths: []string{"/a.js", "/b.js"},
+		options: config.Options{
+			IsBundling:    true,
+			CodeSplitting: true,
+			OutputFormat:  config.FormatESModule,
+			AbsOutputDir:  "/out",
+		},
+		expected: map[string]string{
+			"/out/a.js": `// /a.js
+import("./b.js");
+`,
+			"/out/b.js": `// /b.js
+var b_default = 1;
+export {
+  b_default as default
+};
+`,
+		},
+	})
+}

internal/bundler/linker.go

@@ -823,8 +823,8 @@ func (c *linkerContext) scanImportsAndExports() {
 							otherFileMeta := &c.fileMeta[*record.SourceIndex]
 							if otherFileMeta.entryPointStatus == entryPointNone {
 								c.entryPoints = append(c.entryPoints, *record.SourceIndex)
-								otherFileMeta.entryPointStatus = entryPointDynamicImport
 							}
+							otherFileMeta.entryPointStatus = entryPointDynamicImport
 						}
 					} else {
 						// If we're not splitting, then import() is just a require() that