transformSync output regression in 0.8.22

[eigilsagafos]

After the 0.8.22 release transformSync returns a stringified Uint8Array

[evanw]

I believe you but I am unable to reproduce this. It returns a string for me. This test is currently passing, for example.

Can you provide me with more information? Do you have a code sample that reproduces the problem? What platform is this on?

[eigilsagafos]

@evanw So, I did some more digging. So seems to me that passing a buffer to transformSync is the issue. This has worked before.

Does not work in 0.8.22

const code = readFileSync(filename)
const result = transformSync(code, {
    loader: "ts"
})

Works in 0.8.22

const code = readFileSync(filename)
const result = transformSync(code.toString(), {
    loader: "ts"
})

[evanw]

Ah, I see. That wasn't intentionally supported. This is the type definition for transformSync:

esbuild/lib/types.ts

Line 287 in 9db53e7

export declare function transformSync(input: string, options?: TransformOptions): TransformResult;

I can make sure this isn't silently allowed like it is now.

[eigilsagafos]

I see :) Thanks for pointing that out!