Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module imports ignored via “browser” field cause absolute paths in source maps #786

Closed
eelco opened this issue Feb 11, 2021 · 0 comments · Fixed by #787
Closed

Module imports ignored via “browser” field cause absolute paths in source maps #786

eelco opened this issue Feb 11, 2021 · 0 comments · Fixed by #787

Comments

@eelco
Copy link
Contributor

eelco commented Feb 11, 2021

Follow-up of #785, absolute paths can still happens with module imports.

Example from https://github.com/socketio/engine.io-client/blob/master/package.json#L69-L74:

  "browser": {
    "ws": false,
    "xmlhttprequest-ssl": "./lib/xmlhttprequest.js",
    "./lib/transports/websocket-constructor.js": "./lib/transports/websocket-constructor.browser.js",
    "./lib/globalThis.js": "./lib/globalThis.browser.js"
  },

Causes an absolute path in the source map:

"(disabled):/Users/eelco/Projects/Example/node_modules/engine.io-client/node_modules/ws/browser.js"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant