Add persistent settings #4751
Merged
Add persistent settings #4751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
force-pushed
the
feature/settings
branch
5 times, most recently
from
5fc8f57 to
6a12eb5
Compare
andig
force-pushed
the
feature/settings
branch
from
36438a4 to
95e73c6
Compare
andig
force-pushed
the
feature/settings
branch
from
bd15a81 to
8fb5583
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple interface for storing/retrieving settings from database. Settings provide additional abstractor over the plain
db.Instance.Settings are only saved when
settings.Persist()is called. A corresponding shutdown hook is registered during setup.store.Providerandstore.Storeprovide abstraction for creating a store for a single value and load/save against that store. Using these, individual devices do not need to depend on the settings implementation. See #4838 for example usage.