fix/ownerReference #1078
Merged
fix/ownerReference #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It replaces the `reference` from the ownerReference to a union of string and an object with id and collection. The string refers to the owner id. The object with id and collection keep compatibility with `reference` in case someone use like that. It adds a collection utility to get the owner from the onwerReference. Fix event-catalog#1034
🦋 Changeset detectedLatest commit: bcec21e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
carlosallexandre
changed the title
|
Thanks, just gave it a try and seems to work nicely. Yeah odd how it stopped working all the sudden. Thanks for the PR let's get it in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1034
The actual
ownerReferencekeep resolving to{ id: string, collection: 'users' }for some unknown reason.Changes introduced
It replaces the
referencefrom theownerReferenceto a union of string and an object with id and collection. The string refers to the owner id. The object with id and collection keep compatibility withreferencein case someone use like that.It adds a collection utility to get the owner based on the
onwerReference.