This repository has been archived by the owner on Feb 5, 2025. It is now read-only.
fix([asycnapiu-v2]): sends/received messages are collected correctly #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 40b90c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
XaaXaaX
force-pushed
the
fix/asyncapiv2-pub-sub
branch
from
e7c627b to
223d741
Compare
XaaXaaX
force-pushed
the
fix/asyncapiv2-pub-sub
branch
from
223d741 to
a848cde
Compare
|
Thanks for picking this up @XaaXaaX 🙏 |
|
Fix for #96 |
|
Tested the fix, and works smoothly. 👍🏻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Considering the sends and received messages for asyncapi v2.x
The generator adds the sent and received message to a service this works well for Asyncapi v3 but for Asyncapi v2.x there is a lack of considering operation action == subscribe to let the message be considered as a received message.
The PR adds this possibility and adds the unit tests to validate a simple v2 spec