Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(channels): only adding channels into the service when there are to fix #23 #24

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

IsmaelMartinez
Copy link

@IsmaelMartinez IsmaelMartinez commented Jan 20, 2025

Motivation

Only writing the channels in the service if there are any.

Also, only creating the detail-type badge if there is any detail-type

This fixes #23

Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: daa22ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@IsmaelMartinez
Copy link
Author

happy to create the changelog once I get a thumbs up on this. Thanks again for eventcatalog and for this generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generator creates an empty channel by default - breaks the rendering
1 participant