DEVPROD-8113: Define optional variable before referencing and add support for mongo default variants #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zituo-jin
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Once you fix the bug, be sure to also test the block for mongo default build variants. We should use default regexes in the subsequent build_checks.
| if display_variant_name: | ||
| display_variant_name_checks = display_variant_name | ||
|
|
||
| display_variant_name_checks = display_variant_name |
There was a problem hiding this comment.
This probably won't fix the bug user reported, because he didn't pass display_variant_name explicitly, so the condition if display_variant_name is not None here should have been evaluated False. Maybe it's an empty list or something, not None. We should probably change it to if display_variant_name.
llazala000
changed the title
|
@zituo-jin ran with both our test cases and it worked. I also fixed some tests that needed to be updated with the new changes. |
zituo-jin
approved these changes
Jun 12, 2024
llazala000
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
…port for mongo default variants (#22)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.