EVG-12870: Add trend charts to Spruce task page #451
Conversation
|
@khelif96 Material ui has been removed from the trend-charts in favor of antd |
src/pages/Task.tsx
Outdated
| @@ -40,14 +40,12 @@ import { TestsTable } from "pages/task/TestsTable"; | |||
| import { ExecutionAsDisplay, ExecutionAsData } from "pages/task/util/execution"; | |||
| import { TaskTab, RequiredQueryParams } from "types/task"; | |||
| import { parseQueryString } from "utils"; | |||
| import { TrendCharts } from "./task/TrendCharts"; | |||
| import { TrendChartsPlugin } from "../components/PerfPlugin"; | |||
There was a problem hiding this comment.
We prefer to just use absolute imports you can just do import { TrendChartsPlugin } from "components/PerfPlugin";
package.json
Outdated
| @@ -24,6 +24,7 @@ | |||
| "@leafygreen-ui/text-input": "1.1.1", | |||
| "@leafygreen-ui/toggle": "3.0.1", | |||
| "@leafygreen-ui/typography": "1.0.1", | |||
| "@mongodb-dev-prod/trend-charts-ui": "^0.2.3", | |||
There was a problem hiding this comment.
we should remove the ^ so we can load a previous version of trend-charts-ui and redeploy if needed by only making changes to spruce instead of spruce and trend-charts-ui
There was a problem hiding this comment.
This will coerce lockstep releases with spruce, right? Any patch update to the trend charts ui will have us coming here to update this line. If you want to load and redeploy a previous version by only changing spruce, it seems like this would be the line to edit at that point. On our end it would be convenient to just iterate major/minor/patch versions with some care, and this UI to consume updates as appropriate, e.g. fixed major/minor version and latest patch.
There was a problem hiding this comment.
It's not a hard requirement for us to exclude the caret and I am for including the caret if it can benefit your workflow.
Something to consider if we include the caret is that there isn't an easy way to tell which version of trend-charts-ui is deployed in spruce by looking at the build/dist files (you can see the output in the build folder by running npm run build in spruce). The most convenient way to understand which version of trend-charts-ui is deployed in Spruce would be to see what was available in the trend-charts-ui npm module at the time of the most recent spruce deploy (that would require you to find the most recent spruce deploy message in the evergreen-deploys slack channel). Let me know what ya'll think!
There was a problem hiding this comment.
That should be fine. We can do ~ instead if that makes you more comfortable so that we're only automatically updating on patch updates. That way we don't have to bother yall with bug fixes or small changes but are marking the times when we're making larger changes. Does that sound good?
|
The compile and e2e test tasks are OOMing. |
Fixed now |
src/pages/Task.tsx
Outdated
| @@ -127,6 +125,16 @@ const TaskCore: React.FC = () => { | |||
| taskStatus: task?.status, | |||
| }); | |||
|
|
|||
| if (isPerfPluginEnabled) { | |||
There was a problem hiding this comment.
when both plugins are enabled, the tabToIndexMap contains non-integer numbers and values repeat across the keys: {"logs":0,"tests":1,"files":2,"trend-charts":3.5,"build-baron":3.5}. I
There was a problem hiding this comment.
Whoops, nice catch! Should be fixed now and handle any combination of them being enabled
zamj
force-pushed
the
EVG-12870
branch
2 times, most recently
from
524a810 to
ec344a4
Compare
|
Good to go after we sort out the tabs not rendering properly |
Should be good to try now |
|
Thanks for all of this! |
|
The compile task is still OOMing I think you accidently removed the flag to allocate it more memory |
Whoops, good catch! |
There's still some work to be done before Trend Charts are complete so we're still going to leave it off for now. When the final feature PR is in, we'll have to add the prod url to the settings