Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The product registration does not list all child categories #630

Closed
leandrosantoss opened this issue Sep 17, 2024 · 18 comments
Closed
Assignees

Comments

@leandrosantoss
Copy link

leandrosantoss commented Sep 17, 2024

Describe the bug
The product registration does not list all child categories

Screenshots
image

image

image
This child category was not found in the category tree in product registration

image
Clicking to expand "Tabacaria"

In the Data Base the category "Tabacaria" has 75 rows
image

Background (please complete the following information):

  • NodeJS 20
  • EverShop 1.2.1
@leandrosantoss
Copy link
Author

Hi @treoden I believe it is the same problem that happens in GraphQL. The query is limited and I need to send the "limit" in the filter for it to work.

@leandrosantoss
Copy link
Author

@treoden this is a Critical bug for me

image

Some change was made and it is limiting the system. Here it only lists 20, and in the database I have 114.

image

@leandrosantoss
Copy link
Author

@treoden news about this? This is a critical bug

@omarsoufiane
Copy link

I can help by putting a bounty for solving this issue.

@bountyhub-bot
Copy link

🚀 Bounty Alert!

💰 A bounty of $30.00 has been created by omarsoufiane on BountyHub for this issue.

🔗 Claim this bounty by submitting a pull request that solves this issue!

Good luck, and happy coding! 💻

@rahat2134
Copy link

rahat2134 commented Oct 29, 2024

@leandrosantoss
I understand the bug where only 20 child categories are being displayed in the product registration instead of all 75 categories from the database. This appears to be a pagination/limit issue in the GraphQL query. The solution would involve modifying the GraphQL resolver to either remove the default pagination limit or implement proper pagination for the category tree.
I'd like to work on this issue. Could you please assign it to me?

@leandrosantoss
Copy link
Author

This pull request does not solve this problem :(

#654

@risjai
Copy link

risjai commented Oct 30, 2024

@leandrosantoss check this out for the fix : #655
I have attached the video for the working solution. Tested it on my system, works well.

screen-recording-2024-10-30-at-30535-pm_lAevZzT9.mp4

Couple of things :

  • The issue exists not on just the child categories but direct product categories as well.
  • @rahat2134 solution also works but it has many side effects. Eg : Wherever pagination is used like in other pages, it will affect those limits.

Ping me on discord if you have any doubts.

@risjai
Copy link

risjai commented Nov 5, 2024

@omarsoufiane @leandrosantoss can we conclude this?

@omarsoufiane
Copy link

@risjai the issue is about child categories, not main categories, so your pr doesn't fix it ( judging from the code because I didn't test it yet)

@leandrosantoss
Copy link
Author

Can I test in my environment after generating a new release

@risjai
Copy link

risjai commented Nov 6, 2024 via email

@risjai
Copy link

risjai commented Nov 11, 2024

@leandrosantoss Did you test this out?

@risjai
Copy link

risjai commented Nov 20, 2024

@omarsoufiane how do we conclude this?

@omarsoufiane
Copy link

@risjai the PR isn't merged, and I will test it once it's merged

@treoden
Copy link
Collaborator

treoden commented Nov 29, 2024

Hi @leandrosantoss ,

Would you mind trying the last PR?

Thanks

@IIITManjeet
Copy link

Hey, I'd like to attempt the bounty.

@treoden
Copy link
Collaborator

treoden commented Jan 4, 2025

Completed in v1.2.2

@treoden treoden closed this as completed Jan 4, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in EverShop Development Board Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

7 participants