Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Template logic for showing executive positions on term_table cards #13600

Closed
wants to merge 4 commits into from
Closed

WIP: Template logic for showing executive positions on term_table cards #13600

wants to merge 4 commits into from

Conversation

zarino
Copy link
Member

@zarino zarino commented Jul 25, 2016

Part of #13297.

To-do:

  • Update term_table template to handle executive positions
  • Pass executive positions into the template from app.rb
  • Show only most recent position, with "And more…" link for the rest?

@tmtmtmtm tmtmtmtm temporarily deployed to everypolitician-viewe-pr-13600 July 25, 2016 14:06 Inactive
@zarino zarino added the 3 - WIP label Jul 25, 2016
@tmtmtmtm tmtmtmtm temporarily deployed to everypolitician-viewe-pr-13600 July 25, 2016 15:58 Inactive
@chrismytton chrismytton force-pushed the 13297-exec-positions-in-card branch from 950fa51 to d658b2d Compare February 17, 2017 09:11
@tmtmtmtm tmtmtmtm temporarily deployed to everypolitician-viewe-pr-13600 February 17, 2017 09:12 Inactive
@chrismytton
Add position data to person card
91d5ea3 
This connects the data in the “unstable” directory in
everypolitician-data to the person cards on the term pages.

At the moment this is a _very_ hacky prototype. We should at least
address the following:

- Nicer way to fetch position CSV
- Use a class to represent each position, rather than a hash
@tmtmtmtm tmtmtmtm temporarily deployed to everypolitician-viewe-pr-13600 February 17, 2017 09:49 Inactive
@chrismytton chrismytton assigned chrismytton and unassigned tmtmtmtm and zarino Feb 17, 2017
@tmtmtmtm tmtmtmtm temporarily deployed to everypolitician-viewe-pr-13600 February 17, 2017 09:56 Inactive
@chrismytton chrismytton mentioned this pull request Feb 17, 2017
Closed
@chrismytton chrismytton removed their assignment Apr 10, 2017
@zarino zarino closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zarino @chrismytton @tmtmtmtm