Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly universalize dictionaries on Python 2 #723

Closed
evhub opened this issue Mar 4, 2023 · 1 comment
Closed

Properly universalize dictionaries on Python 2 #723

evhub opened this issue Mar 4, 2023 · 1 comment
Labels
compatibility resolved
Milestone
v3.0.0

Comments

@evhub
Copy link
Owner

evhub commented Mar 4, 2023

Should use OrderedDict for all Python 2 dictionaries, but modify it so that dict instances pass isinstance checks.
@evhub evhub added this to the v3.0.0 milestone Mar 4, 2023
@evhub
Copy link
Owner Author

evhub commented Mar 11, 2023

Should also universalize using views instead of lists for .keys, .values, and .items.

@evhub evhub changed the title Make dictionaries ordered on Python 2 Properly universalize dictionaries on Python 2 Mar 11, 2023
@evhub evhub added the resolved label Mar 11, 2023
evhub added a commit that referenced this issue Mar 11, 2023
@evhub
Properly universalize dicts
26b3b7c 
Resolves   #723.
@evhub evhub closed this as completed Mar 11, 2023
@evhub evhub mentioned this issue May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility resolved
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@evhub