-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File watcher #106
File watcher #106
Conversation
Looks good--just a couple of things that either you can fix now or I will fix when I merge it:
|
Ok, I'll work on it. |
Watching files by looping and looking at times is far from good practice, especially when there exist libraries that hook into the host OS and provide you with callbacks when files change: I use gamin:
|
I was trying to keep dependencies to a minimum, but I'll look into it. |
I think introducing more required dependencies is not a good idea, but if you just put the import statement inside of the |
Ok, so the problem with that is watchdogs wants me to subclass one of their classes. This would mean I would need to declare the class in the |
Ok, it now uses watchdogs. |
Looks good! I'll try to merge it soon. |
Added file and directory watching flag. This is as requested in issue #99.
Usage:
I did not use the watchdogs library because I wanted to keep dependencies minimal.