Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export SV in-game #134

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

SafeteeWoW
Copy link
Contributor

@SafeteeWoW SafeteeWoW commented Dec 7, 2017

  • The idea is to add an in-game command to conveniently copy saved variable in-game, instead of asking to upload SV, teaching howto, then waiting for SV every time. Uploading a saved variable file is not simple for most people.
  • Mostly done. I am intended to let you write the description localed in RCLootCouncil:ExportSavedVariable() because I have no idea how you would like to do you. Besides, I have not add an command for it, but it's just two lines of code to call RCLootCouncil:ExportSavedVariable().
  • Definitely paste the text of SV to Curseforge is terrible. Gist is a good place to go. No need to register before using Gist.

Most things to do:

  • Besides the way to copy SV, we should also offer a convenient way to copy & paste website hyperlink to report the issue. I probably should allow more editboxes to be shown
  • Catch LUA error of RCLootCouncil and when this happens, prompt user to report the issue.
  • LootHistory can now use RCLootCouncil:ExportText(text, title, desc)
  • WIP

@SafeteeWoW SafeteeWoW changed the title Dump table in LUA format Export SV in-game Dec 7, 2017
@evil-morfar evil-morfar mentioned this pull request Jan 24, 2018
9 tasks
@evil-morfar
Copy link
Owner

This PR has sat here for so long that it's become a mess of commits.

I still like the idea, but I'll probably extract the actual additions at some point when 3.0 development allows it.

@evil-morfar evil-morfar added v3.0 Notes Notes/discussion to keep in mind for future upadtes and removed v2.8 labels Jul 24, 2018
@evil-morfar evil-morfar removed the v3.0 label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Notes Notes/discussion to keep in mind for future upadtes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants